[PATCH] D24941: [libc++][tests] Fixing some issues in unordered container tests

[Oleg Ranevskyy via llvm-commits]

iid_iunknown created this revision.
iid_iunknown added a reviewer: EricWF.
iid_iunknown added a subscriber: llvm-commits.
iid_iunknown set the repository for this revision to rL LLVM.

Hi Eric,

Would you review these minor corrections for the issues found while running the libc++ tests with _LIBCPP_DEBUG, please?

Below is the summary explaining the motivation for the changes.

1.
- test/std/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
- test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
  //The tests expect the 1st iterator increment to be successful and the 2nd one to trigger _LIBCPP_ASSERT. Actually the assert is triggered by the 1st increment as the container contains no elements.
  Fix: initialize the container with one element.//

2.
- test/std/containers/unord/unord.multiset/db_iterators_8.pass.cpp
- test/std/containers/unord/unord.multiset/db_local_iterators_8.pass.cpp
- test/std/containers/unord/unord.set/db_iterators_8.pass.cpp
- test/std/containers/unord/unord.set/db_local_iterators_8.pass.cpp
  //Container template instantiation passes the allocator type in the wrong place.//

3.
- test/std/containers/unord/unord.multiset/db_iterators_7.pass.cpp
- test/std/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
- test/std/containers/unord/unord.set/db_iterators_7.pass.cpp
- test/std/containers/unord/unord.set/db_local_iterators_7.pass.cpp
  //Same as (1) + (2)//

4.
- test/std/containers/unord/unord.set/emplace_hint.pass.cpp 
- test/std/containers/unord/unord.set/insert_hint_const_lvalue.pass.cpp
- test/std/containers/unord/unord.set/insert_hint_rvalue.pass.cpp
  //Saves the end iterator and then modifies the container invalidating the iterator due to rehashing.//

Thanks!

Repository:
  rL LLVM

https://reviews.llvm.org/D24941

Files:
  test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
  test/std/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
  test/std/containers/unord/unord.multiset/db_iterators_7.pass.cpp
  test/std/containers/unord/unord.multiset/db_iterators_8.pass.cpp
  test/std/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
  test/std/containers/unord/unord.multiset/db_local_iterators_8.pass.cpp
  test/std/containers/unord/unord.set/db_iterators_7.pass.cpp
  test/std/containers/unord/unord.set/db_iterators_8.pass.cpp
  test/std/containers/unord/unord.set/db_local_iterators_7.pass.cpp
  test/std/containers/unord/unord.set/db_local_iterators_8.pass.cpp
  test/std/containers/unord/unord.set/emplace_hint.pass.cpp
  test/std/containers/unord/unord.set/insert_hint_const_lvalue.pass.cpp
  test/std/containers/unord/unord.set/insert_hint_rvalue.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24941.72575.patch
Type: text/x-patch
Size: 11459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160926/621c2032/attachment.bin>