[PATCH] D24830: [ELF] - Linkerscript: implemented BYTE/SHORT/LONG/QUAD commands.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:742-743
@@ +741,4 @@
+    if (auto *DataCmd = dyn_cast<BytesDataCommand>(Base2.get())) {
+      // If the object file format of the output file has an explicit
+      // endianness, the value will be stored in that endianness.
+      writeInt<ELFT>(&Buf[DataCmd->Offset], DataCmd->Data, DataCmd->Size);
----------------
ruiu wrote:
> This comment doesn't make sense to be written here. Probably I'd just remove.
Yeah, initially I wrote it because we have comment for filler saying it works with big-endian,
but for this place there is no disagree between ld, gold and spec, so it was probably excessive, I removed it from commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D24830