[PATCH] D24925: [testsuite] turn fp-contract off for ARM because output checking is not flexible enough

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 12:30:53 PDT 2016


On 26 September 2016 at 20:23, Hal Finkel <hfinkel at anl.gov> wrote:
> This is getting off topic a bit, but given the number of miscompiles we find by self hosting that don't show up in the test suite, and some other experience, I estimate that our test suite should be at least an order of magnitude larger than it is currently. If our current hardware can't handle the test suite duplicating some of the tests using floating-point computation in some different configurations (e.g. FMAs off vs. FMAs on, not to mention -ffp-contract and -ffast-math) we're already in trouble.

Yup. And I think Abe's proposal is a good way forward.

It's probably too big to do before the fp contract changes (if we can
quickly fix the breaking tests, for example), but it's definitely
something we *should* be doing, rather than *could* be doing.

cheers,
--renato


More information about the llvm-commits mailing list