[PATCH] D24441: [AA] Add the notion of target-specific alias analyses.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 11:23:12 PDT 2016


chandlerc added a comment.

While we don't have any way for TTI to register a pass, we do have a way for the *target* to register a pass.

In https://reviews.llvm.org/D24441#551638, @jlebar wrote:

> In https://reviews.llvm.org/D24441#551627, @hfinkel wrote:
>
> > It seems somewhat unfortunate to have both ExternalAAWrapperPass and TargetSpecificAAWrapperPass. It also seems unfortunate that we can only ever have one external AA provider. What if we let ExternalAAWrapperPass contain an array of callbacks and let the target add to that array?
>
>
> That seems simple enough.  We'd need to change the external wrapper pass to use AAResultsProvider (a raw callback isn't going to work for a target-specific pass, see the commit message), but if anything I think that will be a simplification for clients of the external thing.


I think instead, the target *can* actually add a separate pass to provide the AA results, and then you should be able to use the external AA hooks already present. Let me find the place where you can do this from the target.


https://reviews.llvm.org/D24441





More information about the llvm-commits mailing list