[PATCH] D24904: Allow StringRef to be constructed with a null pointer

Chris Lattner via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 11:00:54 PDT 2016

Previous message: [PATCH] D24904: Allow StringRef to be constructed with a null pointer
Next message: [PATCH] D24904: Allow StringRef to be constructed with a null pointer
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

lattner added a comment.

> The 0 is for the length, not the actual pointer.


Oh right, read it too quickly.  I agree with Greg that keeping the deleted nullptr_t ctor is also sensible for this pass.  It would be great to evaluate what happens when the const char*  ctor is made explicit.


https://reviews.llvm.org/D24904

Previous message: [PATCH] D24904: Allow StringRef to be constructed with a null pointer
Next message: [PATCH] D24904: Allow StringRef to be constructed with a null pointer
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list