[PATCH] D24830: [ELF] - Linkerscript: implemented BYTE/SHORT/LONG/QUAD commands.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:742-743
@@ +741,4 @@
+    if (auto *DataCmd = dyn_cast<BytesDataCommand>(Base2.get())) {
+      // If the object file format of the output file has an explicit
+      // endianness, the value will be stored in that endianness.
+      writeInt<ELFT>(&Buf[DataCmd->Offset], DataCmd->Data, DataCmd->Size);
----------------
This comment doesn't make sense to be written here. Probably I'd just remove.


https://reviews.llvm.org/D24830