[PATCH] D24925: [testsuite] turn fp-contract off for ARM because output checking is not flexible enough

[Sanjay Patel via llvm-commits]

spatel created this revision.
spatel added reviewers: Abe, rengolin, hfinkel, scanon, spop, yaxunl, MatzeB.
spatel added a subscriber: llvm-commits.
Herald added subscribers: samparker, mcrosier, rengolin, aemerson.

AFAIK, I don't have any way to test this patch locally. If someone wants to try that first to make sure I haven't botched this, that would be great. :)

Motivation: we want to reinstate D24481 / rL282259 without breaking AArch64 testsuite bots, so let's use the same hack that PowerPC is currently using to overcome the too-strict reference output checks. Ideally, we would do something like rL282027 to customize the checking per test, but let's not gate FMA codegen on that because it might require some serious investigation to get right.

https://reviews.llvm.org/D24925

Files:
  Makefile.config.in

Index: Makefile.config.in
===================================================================
--- Makefile.config.in
+++ Makefile.config.in
@@ -159,6 +159,12 @@
 endif
 endif
 
+# ARM needs -ffp-contract=off so that:
+#     The outputs match the reference outputs.
+ifeq ($(ARCH),ARM)
+TEST_TARGET_FLAGS += -ffp-contract=off
+endif
+
 #
 # Provide variables specific to llvm-test
 #


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24925.72506.patch
Type: text/x-patch
Size: 383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160926/d3d63994/attachment.bin>