[PATCH] D24891: [ELF] Support -z max-page-size option

[George Rimar via llvm-commits]

grimar added a subscriber: grimar.

================
Comment at: test/ELF/linkerscript/zcommon-page-size.s:7
@@ +6,3 @@
+# RUN:       }" > %t.script
+# RUN: ld.lld -z common-page-size=0x1234 -o %t1 --script %t.script %t
+# RUN: llvm-objdump -t %t1 | FileCheck %s
----------------
But should this work ? 
We had a patch for this option earlier: D19600 and its implementation checked that:

```
if (Config->ZMaxPageSize < Target->PageSize ||
  (Config->ZMaxPageSize % Target->PageSize != 0))
    error("wrong page size specified: " + Twine(Config->ZMaxPageSize));
```
This is checks that GNU linkers do (I think both of them, but not really remember now) and this
checks looks reasonable to have for me.



https://reviews.llvm.org/D24891