[PATCH] D24225: [LCG] Add the necessary functionality to the LazyCallGraph to support inlining.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 01:46:33 PDT 2016


chandlerc added a comment.

Sorry I missed the inline comments at first, addressed all but one and responded to that one below.


================
Comment at: lib/Analysis/LazyCallGraph.cpp:1302
@@ +1301,3 @@
+  Parents.clear();
+  for (RefSCC *ParentRC : OldParents)
+    for (SCC *ParentC : ParentRC->SCCs)
----------------
sanjoy wrote:
> Can we put this logic inside `connectRefSCC` ?
We already do related things in connectRefSCC, but there are callers to that which don't need to do the re-analysis?


https://reviews.llvm.org/D24225





More information about the llvm-commits mailing list