[PATCH] D24729: Don't look through addrspacecast in GetPointerBaseWithConstantOffset

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comment addressed.


================
Comment at: test/Transforms/GVN/PRE/rle-addrspace-cast.ll:1
@@ +1,2 @@
+; RUN: opt < %s -basicaa -gvn -S -die | FileCheck %s
+
----------------
You should add a data layout specifier here.  I think that we otherwise pick up the default for a given host which might cause this test to spurious fail.


https://reviews.llvm.org/D24729