[PATCH] D24873: [gold] Split plugin options controlling ThinLTO and codegen parallelism.

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:124
@@ -123,1 +123,3 @@
   static unsigned Parallelism = 0;
+  // Default regular LTO code gen parallelism (number of partitions).
+  static unsigned ParallelCodeGenParallelismLevel = 1;
----------------
davide wrote:
> same here
Done

================
Comment at: tools/gold/gold-plugin.cpp:219
@@ -214,1 +218,3 @@
+              .getAsInteger(10, ParallelCodeGenParallelismLevel))
+        message(LDPL_FATAL, "Invalid code gen partition level: %s", opt_ + 5);
     } else if (opt == "disable-verify") {
----------------
davide wrote:
> Can we either use code generation or codegen (single word?)
Done

================
Comment at: tools/gold/gold-plugin.cpp:707
@@ -706,3 +711,1 @@
   Conf.OptLevel = options::OptLevel;
-  if (options::Parallelism) {
-    if (options::thinlto)
----------------
pcc wrote:
> Can this just be `if (options::Parallelism)`? I'd like us to work towards removing the `thinlto` flag (c.f. D23721).
Done


https://reviews.llvm.org/D24873