[PATCH] D24661: More processors support under AARch64 state for auto detection.

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 06:08:11 PDT 2016


rengolin added a comment.

Two small style comments, but it looks good to me with those changes.

Thanks!
--renato


================
Comment at: include/llvm/Support/TargetParser.h:165
@@ -164,3 +164,3 @@
   AEK_PROFILE = 0x40,
-  AEK_RAS = 0x80
+  AEK_RAS = 0x80,
 };
----------------
There's no need to keep the comma now that you're not changing the list. Once you do, you can leave another on the new tag.

================
Comment at: unittests/Support/TargetParserTest.cpp:549
@@ -549,1 +548,3 @@
+                       "vulcan",
+		       "xgene1"};
 
----------------
keep this in the same line, pls.


https://reviews.llvm.org/D24661





More information about the llvm-commits mailing list