[PATCH] D24844: GVN-hoist: disable hoisting stores past calls (PR30499)

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 14:48:57 PDT 2016


dberlin added a comment.

It also will not work for InvokeInst.

This is what the whole MemoryLocOrCall stuff does in MemorySSA.cpp.
You also need to handle fenceinst, etc

You can resolve this by using getModRefInfo, which has versions for calls and not calls

Just explose MemoryLocOrCall and InstructionClobbersQuery from MemorySSA for now and use that.


https://reviews.llvm.org/D24844





More information about the llvm-commits mailing list