[PATCH] D23988: [compiler-rt][XRay] Support tail call sleds

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 14:13:17 PDT 2016


rSerge requested changes to this revision.
rSerge added a comment.
This revision now requires changes to proceed.

I have another question in https://reviews.llvm.org/D23986 .


================
Comment at: lib/xray/xray_interface.cc:266
@@ +265,3 @@
+      // Here we do the dance of replacing the tail call sled with a similar
+      // sequence as the entry sled, but jump to the exit sled instead, so we
+      // can treat tail call exits as if they were normal exits. In the future
----------------
The comment says about a jump to the exit sled, but the code below uses `CallOpCode`. Which one is wrong?


https://reviews.llvm.org/D23988





More information about the llvm-commits mailing list