[PATCH] D21219: [profile] Cleanup profile file path set up code
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 22 13:49:27 PDT 2016
MatzeB added a subscriber: MatzeB.
================
Comment at: compiler-rt/trunk/lib/profile/InstrProfilingFile.c:339-346
@@ -287,4 +338,10 @@
- NewFile =
- !OldFilenamePat || (strcmp(OldFilenamePat, lprofCurFilename.FilenamePat));
+ if (!OldFilenamePat) {
+ PROF_NOTE("Set profile file path to \"%s\" via %s.\n",
+ lprofCurFilename.FilenamePat, getPNSStr(PNS));
+ } else {
+ PROF_NOTE("Override old profile path \"%s\" via %s to \"%s\" via %s.\n",
+ OldFilenamePat, getPNSStr(OldPNS), lprofCurFilename.FilenamePat,
+ getPNSStr(PNS));
+ }
----------------
So this is breaking our test-suite. Adding extra output to stdout/stderr based on profile settings messes up tests that look for a certain output of a process. Can we remove those notes again?
Repository:
rL LLVM
https://reviews.llvm.org/D21219
More information about the llvm-commits
mailing list