[PATCH] D24597: [cpu-detection] Copy simplified version of get_cpuid_max to remove dependency to clang's implementation

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 11:21:15 PDT 2016


asbirlea added inline comments.

================
Comment at: lib/Support/Host.cpp:172
@@ -175,1 +171,3 @@
 
+// The check below for i386 was copied from clang's cpuid.h (__get_cpuid_max).
+// Check motivated by bug reports for OpenSSL crashing on CPUs without CPUID
----------------
echristo wrote:
> Once we have this here can we get rid of the bits in clang?
There is no usage of this in llvm, clang, openmp or test-suite. However there are external tools using clang that do use the original method.
I don't think that "__get_cpuid_max" can be removed.


https://reviews.llvm.org/D24597





More information about the llvm-commits mailing list