[PATCH] D24748: Win64: Don't emit unwind info for "leaf" functions (PR30337)

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: test/CodeGen/X86/pr24374.ll:34-35
@@ -33,4 +33,3 @@
 ; CHECK-LABEL: g:
-; CHECK:       .seh_proc g
-; CHECK:       .seh_endproc
 
----------------
hans wrote:
> majnemer wrote:
> > Should we make these CHECK-NOT ? Should we do the same for the other tests?
> test/CodeGen/X86/win64_eh_leaf.ll checks that we don't emit these directives for leaf functions, and I'm not sure there's any benefit to add check-nots in other test just to check for the same thing.
> 
> I'm happy to add it here though if you think there's really a benefit to it.
I guess I feel most strongly about win64_eh.ll. It contains examples of increasing complexity with the varied results we'd expect from the compiler, I feel like it'd be useful to include the CHECK-NOTs for pedagogical purposes.


https://reviews.llvm.org/D24748