[PATCH] D24832: [ELF] Resolve weak undefined TLS symbols when no phdr is available

[Davide Italiano via llvm-commits]

davide created this revision.
davide added a reviewer: rafael.
davide added a subscriber: llvm-commits.

If we pass --gc-sections to lld and .tbss is not referenced, it gets reclaimed and we don't create a TLS program header. 
R_TLS tries to access the program header -> lld crashes. Mimic what bfd/gold do in this case and resolve a weak undefined TLS symbol to the base of the TLS block, i.e. give it a value of zero.

https://reviews.llvm.org/D24832

Files:
  ELF/InputSection.cpp
  test/ELF/tls-weak-undef.s

Index: test/ELF/tls-weak-undef.s
===================================================================
--- /dev/null
+++ test/ELF/tls-weak-undef.s
@@ -0,0 +1,11 @@
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld %t.o %t.a -o %t --gc-sections
+
+// Check that lld doesn't crash because we don't reference
+// the TLS phdr when it's not created.
+        .globl  _start
+_start:
+        movq    foo at gottpoff(%rip), %rax
+        .section        .tbss,"awT", at nobits
+        .weak   foo
Index: ELF/InputSection.cpp
===================================================================
--- ELF/InputSection.cpp
+++ ELF/InputSection.cpp
@@ -241,6 +241,13 @@
   case R_RELAX_TLS_IE_TO_LE:
   case R_RELAX_TLS_GD_TO_LE:
   case R_TLS:
+    // A weak undefined TLS symbol resolves to the base of the TLS
+    // block, i.e. gets a value of zero. If we pass --gc-sections to
+    // lld and .tbss is not referenced, it gets reclaimed and we don't
+    // create a TLS program header. Therefore, we resolve this
+    // statically to zero.
+    if (Body.isTls() && Body.isLazy() && Body.symbol()->isWeak())
+      return 0;
     if (Target->TcbSize)
       return Body.getVA<ELFT>(A) +
              alignTo(Target->TcbSize, Out<ELFT>::TlsPhdr->p_align);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24832.72185.patch
Type: text/x-patch
Size: 1294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160922/53969343/attachment.bin>