[PATCH] D24735: Triple: Add opencl environment type

[Chandler Carruth via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D24735#547361, @tstellarAMD wrote:

> In https://reviews.llvm.org/D24735#547257, @pekka.jaaskelainen wrote:
>
> > Makes sense to me. How to differentiate between OpenCL implementations? With the OS setting?
>
>
> I was thinking  the vendor field could be used for this.  So, for example, if pocl used the hsa runtime, the triple would be: amdgcn-pocl-amdhsa-opencl.


Just as an FYI:

Generally the vendor shouldn't be used to control *semantics* anywhere. It should just be used to find tools or label things.

If you have a different ABI, you want a different environment entry typically.

In that sense this seems like a nice improvement.


https://reviews.llvm.org/D24735