[PATCH] D23089: llc: Add -start-before/-stop-before options

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 15:45:21 PDT 2016


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: include/llvm/CodeGen/TargetPassConfig.h:151
@@ +150,3 @@
+           "Start after and start before passes are given");
+    assert(!(StopBefore && StopAfter) &&
+           "Stop after and stop before passed are given");
----------------
hfinkel wrote:
> These asserts should be report_fatal_error; the user might trigger them with bad command-line options (and I assume we still want them in release builds).
Agreed. A follow-up commit is fine given we use to assert on that already.


Repository:
  rL LLVM

https://reviews.llvm.org/D23089





More information about the llvm-commits mailing list