[PATCH] D24748: Win64: Don't emit unwind info for "leaf" functions (PR30337)

[Hans Wennborg via llvm-commits]

hans marked 3 inline comments as done.

================
Comment at: include/llvm/CodeGen/MachineFunction.h:378-379
@@ -374,1 +377,4 @@
 
+  bool hasWinCFI() const { return HasWinCFI; }
+  void setHasWinCFI(bool v) { HasWinCFI = v; }
+
----------------
rnk wrote:
> majnemer wrote:
> > I'd sleep a little easier at night if `HasWinCFI` was an optional bool.  This way we can make sure that nobody is trying to access it before we calculate the state the function is in.
> This is a good idea, we should do this more often.
That's a great idea. Done.

================
Comment at: test/CodeGen/X86/win64_eh.ll:5-14
@@ -4,12 +4,1 @@
 
-; Check function without prolog
-define void @foo0() uwtable {
-entry:
-  ret void
-}
-; WIN64-LABEL: foo0:
-; WIN64: .seh_proc foo0
-; WIN64: .seh_endprologue
-; WIN64: ret
-; WIN64: .seh_endproc
-
----------------
majnemer wrote:
> Why did this test get removed?
I wasn't sure what to do with it now that we don't emit anything special for it. I'll put it back and check it's there and has the ret.


https://reviews.llvm.org/D24748