[PATCH] D24808: [AArch64] Avoid materializing 0.0 when generating FP CSEL

Evandro Menezes via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 13:33:49 PDT 2016


evandro marked 2 inline comments as done.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4083
@@ +4082,3 @@
+
+  if (DAG.getTarget().Options.UnsafeFPMath) {
+    // Transform "a == 0.0 ? 0.0 : x" to "a == 0.0 ? a : x" and
----------------
evandro wrote:
> gberry wrote:
> > Isn't the goal to check these options less and look at the DAG node flags instead?
> > If so, this might be better written as follows?
> >   DAG.getFlags()->hasNoSignedZeros()
> Yes, thank you!
Am I missing something or `SelectionDAG` has no such method?  Not all `SDValue` have `SDNodeFlags` either...


Repository:
  rL LLVM

https://reviews.llvm.org/D24808





More information about the llvm-commits mailing list