[PATCH] D24334: [EfficiencySanitizer] Using '$' instead of '#' for struct counter name

Qin Zhao via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 12:20:08 PDT 2016


zhaoqin accepted this revision.
zhaoqin added a comment.
This revision is now accepted and ready to land.

LGTM with nits
Please test before commit.


================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:315
@@ -314,3 +314,3 @@
   // We allow the actual size of the StructCounterName to be larger than
   // MaxStructCounterNameSize and append #NumFields and at least one
   // field type id.
----------------
Replace # in the comment

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:317
@@ -316,2 +316,3 @@
   // field type id.
   // Append #NumFields.
+  NameStr += "$";
----------------
ditto


Repository:
  rL LLVM

https://reviews.llvm.org/D24334





More information about the llvm-commits mailing list