[PATCH] D24597: [cpu-detection] Copy simplified version of get_cpuid_max to remove dependency to clang's implementation

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 11:50:21 PDT 2016


On Tue, Sep 20, 2016 at 10:35 PM Alina Sbirlea via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

On Sep 20, 2016 6:12 PM, "Eric Christopher" <echristo at gmail.com> wrote:
>
> echristo added inline comments.
>
> ================
> Comment at: lib/Support/Host.cpp:172
> @@ -175,1 +171,3 @@
>
> +// The check below for i386 was copied from clang's cpuid.h
(__get_cpuid_max).
> +// Check motivated by bug reports for OpenSSL crashing on CPUs without
CPUID
> ----------------
> Once we have this here can we get rid of the bits in clang?

Do you mean no longer including cpuid.h here (done), or removing the method
in clang (doubt that is the case, but need to check), or something else?
Could you elaborate, please?



I mean removing the code in clang.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160921/563d1ab2/attachment.html>


More information about the llvm-commits mailing list