[PATCH] D24564: [LoopInterchange] Track all dependencies, not just anti dependencies.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 11:27:52 PDT 2016


mcrosier added inline comments.

================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:120
@@ +119,3 @@
+        // Track Output, Flow, and Anti dependencies.
+        if (D->isOrdered()) {
+          DEBUG(StringRef DepType =
----------------
mssimpso wrote:
> I'm not sure this check is needed. The unordered dependences are input dependences (RAR). It looks like the RAR case is explicitly checked a few lines up.
You are correct; I don't think we need the check.  I was thinking it would make the code a bit more readable.  However, I'm fine with changing it to an assert and reducing the indent..  I think that would accomplish the same thing.


https://reviews.llvm.org/D24564





More information about the llvm-commits mailing list