[PATCH] D21409: Emit a swap for STXVD2X when it's emitted by matching a 'store' node

Kit Barton via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 11:12:08 PDT 2016


kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

One minor request for a comment, aside from that LGTM.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:123
@@ -122,3 +122,3 @@
                         [(store f64:$XT, xoaddr:$dst)]>;
 
     def STXVD2X : XX1Form<31, 972,
----------------
Please add a comment here that this pattern is intentionally left blank to catch an error case that should not happen (because everything should be handled by SDAG ISel). 


Repository:
  rL LLVM

https://reviews.llvm.org/D21409





More information about the llvm-commits mailing list