[PATCH] D24781: [ubsan] Respect log_to_syslog=1 on Darwin

[Vedant Kumar via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D24781#548353, @zaks.anna wrote:

> What I was trying to say is that you need CrashReport logging since it will be what users expect based on other tools (ASan and TSan) and will be important in workflows that do not include lldb, such as Xcode Test integration when running without the debugger.


Ah, right, I see why this is needed now. Actually, it already works. Running with UBSAN_OPTIONS="halt_on_error=1" prints a report to the terminal, emits a *.crash file with a copy of the report, and then aborts. This is handled by LogMessageOnPrintf.

It sounds like I can't update LogMessageOnPrintf to log when abort_on_error isn't set, because it could trigger double-locking situations in the other sanitizers. So, would it be OK to pursue the other option: "introduce Mac-specific logic to remove color codes in the PrintToLog function introduced by this patch"?


https://reviews.llvm.org/D24781