[PATCH] D23757: cmake: Support overriding Sphinx HTML doc install directory

[Dan Liew via llvm-commits]

delcypher requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: cmake/modules/AddSphinxTarget.cmake:60
@@ +59,3 @@
+
+        install(DIRECTORY "${SPHINX_BUILD_DIR}/."
+                DESTINATION "${${project_upper}_INSTALL_SPHINX_HTML_DIR}")
----------------
I see. There should be a comment explaining this then.

================
Comment at: docs/CMake.rst:461
@@ +460,3 @@
+  The path to install Sphinx-generated HTML documentation to. Defaults to
+  /usr/share/doc/llvm/html.
+
----------------
This default is incorrect. The default is actually `share/doc/llvm/html`. It does not contain the `CMAKE_INSTALL_PREFIX`.

Your text probably ought to say something like:

```
The path to install Sphinx-generated HTML documentation to. This path relative to the CMAKE_INSTALL_PREFIX and by default
is `share/doc/llvm/html`.
```


https://reviews.llvm.org/D23757