[llvm] r282058 - Revert "AArch64: Set shift bit of TLSLE HI12 add instruction"

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 01:24:41 PDT 2016


Author: rovka
Date: Wed Sep 21 03:24:41 2016
New Revision: 282058

URL: http://llvm.org/viewvc/llvm-project?rev=282058&view=rev
Log:
Revert "AArch64: Set shift bit of TLSLE HI12 add instruction"

This reverts commit r282057 because it broke the buildbots - see e.g.
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/12063

Removed:
    llvm/trunk/test/MC/AArch64/tls-add-shift.s
Modified:
    llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp

Modified: llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp?rev=282058&r1=282057&r2=282058&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp Wed Sep 21 03:24:41 2016
@@ -263,12 +263,6 @@ AArch64MCCodeEmitter::getAddSubImmOpValu
 
   ++MCNumFixups;
 
-  // Set the shift bit of the add instruction for relocation types
-  // R_AARCH64_TLSLE_ADD_TPREL_HI12 and R_AARCH64_TLSLD_ADD_DTPREL_HI12.
-  AArch64MCExpr::VariantKind RefKind = cast<AArch64MCExpr>(Expr)->getKind();
-  if (RefKind == AArch64MCExpr::VK_TPREL_HI12 ||
-      RefKind == AArch64MCExpr::VK_DTPREL_HI12)
-    ShiftVal = 12;
   return ShiftVal == 0 ? 0 : (1 << ShiftVal);
 }
 

Removed: llvm/trunk/test/MC/AArch64/tls-add-shift.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/tls-add-shift.s?rev=282057&view=auto
==============================================================================
--- llvm/trunk/test/MC/AArch64/tls-add-shift.s (original)
+++ llvm/trunk/test/MC/AArch64/tls-add-shift.s (removed)
@@ -1,12 +0,0 @@
-// RUN: llvm-mc -triple=aarch64-none-linux-gnu -filetype=obj < %s -o - | \
-// RUN:   llvm-objdump -r -d - | FileCheck %s
-
-	// TLS add TPREL
-	add x2, x1, #:tprel_hi12:var
-// CHECK: add x2, x1, #0, lsl #12
-// CHECK-NEXT: R_AARCH64_TLSLE_ADD_TPREL_HI12 var
-
-	// TLS add DTPREL
-	add x4, x3, #:dtprel_hi12:var
-// CHECK: add x4, x3, #0, lsl #12
-// CHECK-NEXT: R_AARCH64_TLSLD_ADD_DTPREL_HI12 var




More information about the llvm-commits mailing list