[PATCH] D24781: [ubsan] Respect log_to_syslog=1 on Darwin

Anna Zaks via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 14:16:34 PDT 2016


zaks.anna added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_common_libcdep.cc:41
@@ +40,3 @@
+  // The macOS syslog viewer doesn't know what to do with color codes.
+  if (common_flags()->log_to_syslog)
+    return false;
----------------
Doesn't this strip coloring from all outputs whenever log_to_system is set? I think what we want is not to show the coloring only in syslog and in the CrashLogs on the mac.

Please, see 
https://reviews.llvm.org/D15396
(and it's predecessor http://reviews.llvm.org/D13452)


https://reviews.llvm.org/D24781





More information about the llvm-commits mailing list