[PATCH] D24780: [RS4GC] Refactor code for Rematerializing in presence of phi. NFC

Anna Thomas via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 13:08:39 PDT 2016


anna created this revision.
anna added reviewers: reames, sanjoy.
anna added a subscriber: llvm-commits.

This is an NFC refactoring change as a precursor to the actual fix for rematerializing in
presence of phi.
https://reviews.llvm.org/D24399

Pasted from review:
findRematerializableChainToBasePointer changed to return the root of the
chain. instead of true or false.
move the PHI matching logic into the caller by inspecting the root return value.
This includes an assertion that the alternate root is in the liveset for the
call.

Tested with current RS4GC tests.

https://reviews.llvm.org/D24780

Files:
  lib/Transforms/Scalar/RewriteStatepointsForGC.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24780.71972.patch
Type: text/x-patch
Size: 7690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160920/0a193a5b/attachment.bin>


More information about the llvm-commits mailing list