[PATCH] D24683: [DAGCombine] Generalize build_vector -> vector_shuffle combine for more than 2 inputs

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 11:14:42 PDT 2016


mkuper added a comment.

In https://reviews.llvm.org/D24683#547611, @RKSimon wrote:

> Sorry for not being clear, but yes my concern was whether the createBuildVecShuffle refactor should be done first as it would make the rest of the patch easier to follow. My proposal for the order of work was based on trying to reduce the size of each patch and show the effect of each feature addition. I can understand if you don't want to take that approach though.


Oh, I see what you mean now (I hope. :-) )
I don't think an NFC refactoring would make sense here - implementing a separate shuffle and blend stages would look really odd for only two inputs. I tried to minimize the changes I'm making here by committing https://reviews.llvm.org/rL281283 first, but I guess that didn't help too much.


https://reviews.llvm.org/D24683





More information about the llvm-commits mailing list