[PATCH] D24773: [asan] Fix GlobalAddressDescription::Print()
Filipe Cabecinhas via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 11:03:19 PDT 2016
filcab created this revision.
filcab added reviewers: kcc, vitalybuka, eugenis.
filcab added a subscriber: llvm-commits.
Herald added a subscriber: kubabrecka.
Check bug_type for nullptr before calling internal_strcmp
https://reviews.llvm.org/D24773
Files:
lib/asan/asan_descriptions.cc
test/asan/TestCases/global-address.cpp
Index: test/asan/TestCases/global-address.cpp
===================================================================
--- /dev/null
+++ test/asan/TestCases/global-address.cpp
@@ -0,0 +1,12 @@
+// RUN: %clangxx_asan -o %t %s
+// RUN: not %run %t | FileCheck %s
+#include <sanitizer/allocator_interface.h>
+
+int g_i = 42;
+int main() {
+ // CHECK: AddressSanitizer: attempting to call __sanitizer_get_allocated_size() for pointer which is not owned
+ // CHECK-NOT: ASAN:DEADLYSIGNAL
+ // CHECK: SUMMARY: AddressSanitizer: bad-__sanitizer_get_allocated_size
+ // CHECK-NOT: ASAN:DEADLYSIGNAL
+ return (int)__sanitizer_get_allocated_size(&g_i);
+}
Index: lib/asan/asan_descriptions.cc
===================================================================
--- lib/asan/asan_descriptions.cc
+++ lib/asan/asan_descriptions.cc
@@ -323,7 +323,8 @@
void GlobalAddressDescription::Print(const char *bug_type) const {
for (int i = 0; i < size; i++) {
DescribeAddressRelativeToGlobal(addr, access_size, globals[i]);
- if (0 == internal_strcmp(bug_type, "initialization-order-fiasco") &&
+ if (bug_type &&
+ 0 == internal_strcmp(bug_type, "initialization-order-fiasco") &&
reg_sites[i]) {
Printf(" registered at:\n");
StackDepotGet(reg_sites[i]).Print();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24773.71956.patch
Type: text/x-patch
Size: 1287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160920/dfc4cacd/attachment.bin>
More information about the llvm-commits
mailing list