[PATCH] D23680: [ThinLTO] Emit files for distributed builds for all modules

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 10:50:15 PDT 2016


mehdi_amini added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:6111
@@ -6107,1 +6110,3 @@
+          SeenValueSymbolTable = true;
+        }
         SeenGlobalValSummary = true;
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > Can you commit this as a separate patch? This is mostly unrelated to the distributed build.
> It is related to the change to always emit a summary when compiling for ThinLTO. Maybe I should split that portion (along with the corresponding fixes like this one) out into a separate patch. Is that what you meant? It fixes part of the distributed build issue.
It also change the behavior outside of distributed build right?
It will make files that we didn't include in ThinLTO before, part of the ThinLTO partitions now.


https://reviews.llvm.org/D23680





More information about the llvm-commits mailing list