[PATCH] D23680: [ThinLTO] Emit files for distributed builds for all modules

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 10:37:12 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:6111
@@ -6107,1 +6110,3 @@
+          SeenValueSymbolTable = true;
+        }
         SeenGlobalValSummary = true;
----------------
mehdi_amini wrote:
> Can you commit this as a separate patch? This is mostly unrelated to the distributed build.
It is related to the change to always emit a summary when compiling for ThinLTO. Maybe I should split that portion (along with the corresponding fixes like this one) out into a separate patch. Is that what you meant? It fixes part of the distributed build issue.


https://reviews.llvm.org/D23680





More information about the llvm-commits mailing list