[PATCH] D23727: [Profile] SelectInst instrumentation Support in IR-PGO

[Xinliang David Li via llvm-commits]

On Tue, Sep 20, 2016 at 12:09 AM, Sanjoy Das
<sanjoy at playingwithpointers.com> wrote:
> sanjoy added a subscriber: sanjoy.
> sanjoy added a comment.
>
> Random drop by comment inline.
>
>
> ================
> Comment at: llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp:228
> @@ +227,3 @@
> +  auto *IncWithStep = dyn_cast<InstrProfIncrementInstStep>(Inc);
> +  if (IncWithStep)
> +    return IncWithStep->getStep();
> ----------------
> One out of context comment here -- can't this logic be part of `dyn_cast` via the `classof` you addd to `InstrProfIncrementInstStep`?
>
>

Do you mean getStep method can be defined in the base class here? yes,
that can be done.

thanks,

David


> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D23727
>
>
>