[PATCH] D24517: GVN-hoist: fix store past load dependence analysis (PR30216)

[Sebastian Pop via llvm-commits]

sebpop added a comment.

On Thu, Sep 15, 2016 at 11:11 AM, Daniel Berlin <dberlin at dberlin.org> wrote:

> Sadly, I think this will fail when the use-opt limit is hit.


What about committing the patch that I already sent:

> The current patch visits all loads on the path from the store to

>  be hoisted to the hoisting position and uses the alias analysis

>  to ask whether the store may alias the load.


I think the patch is already quite efficient in terms of compile time
because we limit the hoist distance to avoid register pressure issues.
Because the number of instructions on the path is bounded, we
will also have the bounds on the number of alias questions asked.

Danny, is it okay to commit the patch as it is?


https://reviews.llvm.org/D24517