[PATCH] D24354: cmake: Install the OCaml libraries into a more correct path

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 07:28:05 PDT 2016


mgorny added a reviewer: jpdeplaix.

================
Comment at: cmake/modules/AddOCaml.cmake:214
@@ -212,1 +213,3 @@
 
+add_custom_target(ocaml_make_directory
+  COMMAND "${CMAKE_COMMAND}" "-E" "make_directory" "${LLVM_LIBRARY_DIR}/ocaml/llvm")
----------------
whitequark wrote:
> whitequark wrote:
> > ""
> This also needs to have a reverse dependency, or else you'll break make -j.
I'm sorry but I don't understand you. What kind of a reverse dependency? The ocaml_* targets depend on ocaml_make_directory so that the directory will be created before any of the POST_BUILD commands are executed. Is there anything else that needs to be covered?


https://reviews.llvm.org/D24354





More information about the llvm-commits mailing list