[PATCH] D24757: [cmake] Reintroduce (ldconfig-compatible) SOVERSIONs on shared libraries

[Michał Górny via llvm-commits]

mgorny created this revision.
mgorny added reviewers: beanz, loladiro, tstellarAMD, chapuni, pete.
mgorny added a subscriber: llvm-commits.
Herald added subscribers: mgorny, beanz, wdng.

Reintroduce versioning of shared libraries via SOVERSION, addressing the issues with the previous design, since Gentoo is relying on shared-split install of LLVM. The SOVERSIONs were originally introduced in r229720 for all libraries, and removed in r252093 in favor of custom SONAME. As far as I understand, the major concern with the old versioning was that the used versions were incompatible with ldconfig.

Having considered that, this commit introduce SOVERSIONS with the following considerations:

1. SOVERSIONs are formed of major & minor version concatenated -- i.e. for 4.0 its .so.40. This matches the common practice where the first version number indicates ABI breakage, and therefore fixes the issues
with ldconfig. Additionally, VERSION with the remaining verion components appended is used, however this is not strictly necessary.

2. The versioning is only applied to libraries with no explicit SONAME specified -- i.e. it won't apply to libLLVM but only to the split libraries. It will also apply to libraries installed by the subprojects.

3. The versioning is only done on *nix systems, Darwin excluded. This matches the current use of SONAME.

https://reviews.llvm.org/D24757

Files:
  cmake/modules/AddLLVM.cmake

Index: cmake/modules/AddLLVM.cmake
===================================================================
--- cmake/modules/AddLLVM.cmake
+++ cmake/modules/AddLLVM.cmake
@@ -450,6 +450,18 @@
         PREFIX ""
         )
     endif()
+
+	# Set SOVERSION on shared libraries that lack explicit SONAME
+	# specifier, on *nix systems that are not Darwin.
+    if(UNIX AND NOT APPLE AND NOT ARG_SONAME)
+      set_target_properties(${name}
+        PROPERTIES
+		# Concatenate the version numbers since ldconfig expects exactly
+		# one component indicating the ABI version, while LLVM uses
+		# major+minor for that.
+        SOVERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_MINOR}
+        VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX})
+    endif()
   endif()
 
   if(ARG_MODULE OR ARG_SHARED)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24757.71911.patch
Type: text/x-patch
Size: 836 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160920/46f9e8fa/attachment.bin>