[llvm] r268539 - [AArch64] Use the reciprocal estimation machinery

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 03:11:17 PDT 2016


On 20 September 2016 at 01:49, Eric Christopher via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> I'm going to ask you to revert this patch please. There are a few reasons:

I agree.


> a) I don't see a review thread here? This changes the port quite a bit.

There were some discussions around this topic, and from what
everyone's saying, it's a complex topic.

https://llvm.org/bugs/show_bug.cgi?id=27107
http://lists.llvm.org/pipermail/llvm-dev/2016-September/104676.html

We can't just decide this based on flags (*especially not* isExynosM1()!).

Please revert this and join the discussion upstream.

cheers,
--renato


More information about the llvm-commits mailing list