[PATCH] D24706: [ELF] - Partial support of --gdb-index command line option (Part 1).

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:81
@@ +80,3 @@
+  // and 5 more fields with different kinds of offsets.
+  CuListOffset = 6 * OffsetTypeSize;
+  CuTypesOffset = CuListOffset + CompilationUnits.size() * CompilationUnitSize;
----------------
According to the comment, `CuListOffset` can be a compile-time constant rather than computing at runtime here.

================
Comment at: ELF/OutputSections.cpp:114
@@ +113,3 @@
+  // Write the CU list.
+  for (std::pair<uintX_t, uintX_t>& CU : CompilationUnits) {
+    write64le(Buf, CU.first);
----------------
I think you can just make a copy here (i.e. remove `&`)

================
Comment at: ELF/SplitDebugInfo.cpp:10
@@ +9,3 @@
+//
+// File contains classes for implementation of --gdb-index command line option.
+//
----------------
aprantl wrote:
> Any way this could be doxygen-ified?
Part of this file comment was a copy from other document. You need to add citation.

================
Comment at: ELF/SplitDebugInfo.h:58
@@ +57,3 @@
+// separate object file section called ".debug_abbrev".
+// Defines the abbreviation codes used by the skeleton .debug_info section.
+template <class ELFT> class DwarfAbbrevTable {
----------------
aprantl wrote:
> Please convert all of these top-level class comments to Doxygen comments by using `///`
We do not use doxygen-style comments in any file in this directory. Maybe we should, but we probably should do it all at once in a different patch.


https://reviews.llvm.org/D24706