[PATCH] D24687: [llvm-cov] Add a project coverage summary above the index page.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 14:24:23 PDT 2016


vsk added a comment.

> Currently, the project coverage summary is given in the bottom row of the index table. If there are a large number of source files listed in the index table, the summary row is not immediately visible. This patch adds the project coverage summary above the index page to improve the report readability.


I'd prefer to just tackle this issue in this patch. IMO it would be better to drop (or at least defer) the other changes.

> I have also added the project directory to the summary.


I don't think this clarifies anything, and would prefer not to add it.

> In addition, filenames are only shown as a part of path name in the filename column of the index page. If the file path includes many directory levels, this column doesnÎéÎ÷t look nice.


This is intentional and it matches the behavior of the text reports. The longest-common prefix of the path names are stripped away to make it easier to see the filename. This prefix is visually distracting and doesn't convey any useful information.


https://reviews.llvm.org/D24687





More information about the llvm-commits mailing list