[PATCH] D24737: [scudo] Modify Scudo to use its own Secondary Allocator

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 11:50:20 PDT 2016


kcc added inline comments.

================
Comment at: lib/scudo/scudo_allocator_secondary.h:10
@@ +9,3 @@
+///
+/// TODO(kostyak): description.
+///
----------------
Fix TODO

================
Comment at: lib/scudo/scudo_allocator_secondary.h:26
@@ +25,3 @@
+
+  void Init(bool AllocatorMayReturnNull) {
+    initLinkerInitialized(AllocatorMayReturnNull);
----------------
Just have Init()
InitLinkerInitialized has lots its meaning, and  anyway the other have it with capital I


https://reviews.llvm.org/D24737





More information about the llvm-commits mailing list