[PATCH] D23933: [XRay] ARM 32-bit no-Thumb support in compiler-rt

[Serge Rogatch via llvm-commits]

rSerge added a comment.

I've tested

  .arch armv6t2
  .fpu vfpv2

with Clang cross-compiling from x86_64-Windows to ARM-Linux and Thumb-Linux, and GCC cross-compiling from x86_64-Ubuntu to ARM-Linux and Thumb-Linux. No compile errors so far.


================
Comment at: lib/xray/xray_arm.cc:1
@@ +1,2 @@
+//===-- xray_arm.cpp --------------------------------------------*- C++ -*-===//
+//
----------------
rengolin wrote:
> rSerge wrote:
> > dberris wrote:
> > > nit: s/xray_arm.cpp/xray_arm.cc/
> > Sorry, I'm not that good with the lingo. What is the meaning of this comment?
> It means the name on the comment is wrong and you have to *replace* (s///) with the right one.
> 
> You're calling it `xray_arm.cc` but has `xray_arm.cpp` in the header.
I just did it by example. Ok, I'm fixing the comment


https://reviews.llvm.org/D23933