[PATCH] D23824: [ADCE] Add handling of PHI nodes when removing control flow

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 10:10:01 PDT 2016


majnemer added inline comments.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:364
@@ -350,1 +363,3 @@
 
+void AggressiveDeadCodeElimination::markPhiLive(llvm::PHINode *PN) {
+  auto &Info = BlockInfo[PN->getParent()];
----------------
I don't think you need llvm:: here.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:367
@@ +366,3 @@
+  // Only need to check this once per block.
+  if(Info.HasLivePhiNodes)
+    return;
----------------
Needs a space after 'if'


https://reviews.llvm.org/D23824





More information about the llvm-commits mailing list