[PATCH] D24544: SpeculativeExecution: Stop using whitelist for costs

[Philip Reames via llvm-commits]

reames added a subscriber: reames.
reames accepted this revision.
reames added a reviewer: reames.
reames added a comment.
This revision is now accepted and ready to land.

I'd suggest looking over the isSafeToSpeculate code carefully.  If we had any bugs there, this whitelist might have been helping to cover over them in practice.  In particular, the default: return true; case in that function looks suspicious.  You might want to convert that into a fully covered switch and cross reference the two lists to make sure this change isn't accidentally semantic.

Assuming you've done the above, LGTM.


https://reviews.llvm.org/D24544