[PATCH] D24725: [ELF] - Linkerscript: implemented --orphan-handling command line option.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 08:26:57 PDT 2016


davide added a comment.

In https://reviews.llvm.org/D24725#546282, @grimar wrote:

> In https://reviews.llvm.org/D24725#546280, @davide wrote:
>
> > I think "error" is good and definitely would've helped catching bugs while we were bringing the FreeBSD kernel up&running with lld.
> >  "discard" seems like a dangerous semantic, at least to me, so I'd like to not implement it, at least for now. Do you have a real use case when it's ok to drop input sections if there's no room to place them in the output?
>
>
> I think it is not about case when "no room", but about all orphans if any. We can remove discard mode, I do not know if it is useful or not, just implemented all what ld has.


Even worse. I think that discarding input sections tout court is very dangerous and I'm not exactly happy supporting it.


https://reviews.llvm.org/D24725





More information about the llvm-commits mailing list