[lld] r281776 - Rename SortSectionPolicy::IgnoreConfig to None.

[Rafael Espíndola via llvm-commits]

I am probably OK with both. One name is based on the semantics, the other
on the spelling in the file.

Given that we tend to name options according to the spelling, I probably
have a small preference for the new name.

Cheers,
Rafael


On 17 September 2016 at 03:55, George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> > // For --sort-section and linkerscript sorting rules.
> >-enum class SortSectionPolicy { None, IgnoreConfig, Alignment, Name,
> Priority };
> >+enum class SortSectionPolicy { Default, None, Alignment, Name, Priority
> };
>
> Honestly I find this renaming very confusing.
> If we are talking about policy of sorting, then clear logic would be that
> None is absence of sorting,
> and Default is sorting by default, which is in out case also absence of
> sorting, but can be something different.
>
> But None here means very different and just reflects the command name of
> linkerscript,
> (which has just wrong name probably) and not the policy at all.
>
>  George.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/28f35b38/attachment.html>