[PATCH] D24627: X86: Do not produce GOT relocations on windows

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 06:08:25 PDT 2016


>
>
> So, what exactly does x86_64-pc-windows-macho mean? Is it producing a COFF
> or a MachO?
>
> It is producing a macho file. But as far as I understand it this firmware
> build does not need and cannot deal with GOT relocations which would not be
> useful on any current windows system anyway.
>
>
That is an annoying special case. Normally when there is an -elf or -macho
at the end we mean a plain elf or macho. For example, producing an ELF that
an ELF loader can use on windows.

Hopefully the case you have is the only use of *-windows-macho, so the
patch is probably OK, but please add a comment explaining it.

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/33a0a286/attachment.html>


More information about the llvm-commits mailing list