[PATCH] D24723: AVX-512: Fixed a bug in lowering saturated operations on KNL
Elena Demikhovsky via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 05:41:04 PDT 2016
delena created this revision.
delena added a reviewer: igorb.
delena added a subscriber: llvm-commits.
delena set the repository for this revision to rL LLVM.
The code is not optimal, but it should be correct, at least.
Repository:
rL LLVM
https://reviews.llvm.org/D24723
Files:
../lib/Target/X86/X86ISelLowering.cpp
../test/CodeGen/X86/xaluo.ll
Index: ../lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- ../lib/Target/X86/X86ISelLowering.cpp
+++ ../lib/Target/X86/X86ISelLowering.cpp
@@ -20841,10 +20841,13 @@
SDValue Sum = DAG.getNode(X86ISD::UMUL, DL, VTs, LHS, RHS);
SDValue SetCC =
- DAG.getNode(X86ISD::SETCC, DL, N->getValueType(1),
+ DAG.getNode(X86ISD::SETCC, DL, MVT::i8,
DAG.getConstant(X86::COND_O, DL, MVT::i32),
SDValue(Sum.getNode(), 2));
+ if (N->getValueType(1) == MVT::i1)
+ SetCC = DAG.getNode(ISD::TRUNCATE, DL, MVT::i1, SetCC);
+
return DAG.getNode(ISD::MERGE_VALUES, DL, N->getVTList(), Sum, SetCC);
}
}
@@ -20854,10 +20857,13 @@
SDValue Sum = DAG.getNode(BaseOp, DL, VTs, LHS, RHS);
SDValue SetCC =
- DAG.getNode(X86ISD::SETCC, DL, N->getValueType(1),
+ DAG.getNode(X86ISD::SETCC, DL, MVT::i8,
DAG.getConstant(Cond, DL, MVT::i32),
SDValue(Sum.getNode(), 1));
+ if (N->getValueType(1) == MVT::i1)
+ SetCC = DAG.getNode(ISD::TRUNCATE, DL, MVT::i1, SetCC);
+
return DAG.getNode(ISD::MERGE_VALUES, DL, N->getVTList(), Sum, SetCC);
}
Index: ../test/CodeGen/X86/xaluo.ll
===================================================================
--- ../test/CodeGen/X86/xaluo.ll
+++ ../test/CodeGen/X86/xaluo.ll
@@ -736,14 +736,24 @@
}
define i1 @bug27873(i64 %c1, i1 %c2) {
+; CHECK-LABEL: bug27873:
+; CHECK: ## BB#0:
+; CHECK-NEXT: movl $160, %ecx
+; CHECK-NEXT: movq %rdi, %rax
+; CHECK-NEXT: mulq %rcx
+; CHECK-NEXT: seto %al
+; CHECK-NEXT: orb %sil, %al
+; CHECK-NEXT: retq
+;
; KNL-LABEL: bug27873:
; KNL: ## BB#0:
; KNL-NEXT: andl $1, %esi
; KNL-NEXT: kmovw %esi, %k0
; KNL-NEXT: movl $160, %ecx
; KNL-NEXT: movq %rdi, %rax
; KNL-NEXT: mulq %rcx
; KNL-NEXT: seto %al
+; KNL-NEXT: andl $1, %eax
; KNL-NEXT: kmovw %eax, %k1
; KNL-NEXT: korw %k1, %k0, %k0
; KNL-NEXT: kmovw %k0, %eax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24723.71813.patch
Type: text/x-patch
Size: 2027 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/2f7ce65a/attachment.bin>
More information about the llvm-commits
mailing list